-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart SwiftUI rewrite #460
base: develop
Are you sure you want to change the base?
Conversation
@mickael-menu Any thoughts about the iOS Deployment Target? This build will fail unless we change some SwiftUI code to be iOS 14 compatible (if that's even possible), or bump it up to iOS 15+. |
Thanks @stevenzeck! We can definitely up the minimum iOS version to 15 or 16 for the Test App. The toolkit must stay at iOS 13 though. |
Updated to 16. I'm happy with this now. |
Co-Authored-By: gatamar <[email protected]>
when i try the command "make spm" in your branch, it has error: ninja@ninja-baidu ~/D/u/TestApp (rewrite-swiftui)> make spm do you know how to fix this? |
You should be using |
This PR is a soft restart of rewriting the TestApp using SwiftUI. It's based on the other
swiftui
branch, but with minimal changes. None of the code that is changed affects the behavior of the UIKit version and thus can be safely merged into develop.One thing that is changed for the UIKit version is the iOS Deployment Target now being 16.0.
@UIApplicationMain
inAppDelegate.swift
and uncomment out@main
inTestApp.swift
.